adamwoolhether
Title: Powerful Command-Line Applications in Go: TestLoadNoFile should expect a non-nil error (page 229)
In func TestLoadNoFile , we create a temp file, delete it, and try to load it.
The test is incorrectly written to expect a nil error when we try to load the (deleted) file. It should expect an error.
cobra/pScan.v3/scan/hostsList_test.go
...
if err := hl.Load(tf.Name()); err != nil {
t.Errorf("Expected no error, got %q instead\n", err)
}
Should be:
...
if err = hl.Load(tf.Name()); err == nil {
t.Errorf("Expected error, got nil\n")
}
Marked As Solved
rgerardi
Hi @adamwoolhether , thanks for posting.
The test as shown in the book is actually correct because the method Load shouldn’t return an error when the file doesn’t exist. Please check the method definition a few pages before.
You can also check it by writing the test as you suggested and verifying that it fails.
The idea behind this logic is allowing the user to specify a file name in the configuration and, if it doesn’t exist, the application creates it when saving the first host.
Hope this helps.
Ricardo
Popular Pragmatic Bookshelf topics
Other popular topics
Categories:
Sub Categories:
Popular Portals
- /elixir
- /rust
- /wasm
- /ruby
- /erlang
- /phoenix
- /keyboards
- /python
- /js
- /rails
- /security
- /go
- /swift
- /vim
- /java
- /clojure
- /emacs
- /haskell
- /typescript
- /svelte
- /onivim
- /kotlin
- /c-plus-plus
- /crystal
- /tailwind
- /react
- /gleam
- /ocaml
- /elm
- /vscode
- /flutter
- /html
- /ash
- /deepseek
- /zig
- /opensuse
- /centos
- /php
- /react-native
- /scala
- /lisp
- /sublime-text
- /textmate
- /nixos
- /debian
- /agda
- /deno
- /django
- /kubuntu
- /arch-linux
- /nodejs
- /ubuntu
- /spring
- /revery
- /manjaro
- /julia
- /diversity
- /lua
- /quarkus
- /markdown
Devtalk Sponsors
Practical resources that improve the lives of professional developers.
We build trusted fault-tolerant systems that scale to billions of users.
Real-time error tracking, performance insights, and observability for devs.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Develop your skills with books, videos, and courses.
Catch errors, track performance, monitor hosts and more.
Enabling companies to succeed by building software people love.
Courses that move you from confusion to "Aha, now I get it!"
Publishing Linux Magazine, ADMIN, and MakerSpace for 25+ years.