PragProg Customers

Engineering Elixir Applications B6.0: Do we really want to publish our docker images before merging the PR? (page 134)

rodgco

rodgco

Engineering Elixir Applications B6.0: Do we really want to publish our docker images before merging the PR? (page 134)

I’m following the activities, and just amended my GitHub workflow triggers and noticed that my docker images were published before the PR was submitted.

I’d rather prefer that the CI part is run when the PR is created, but the build and submission of the package only after it is approved and merged.

Am I getting something wrong here?

2 comments
/book-engineering-elixir-applications
0 39 2

First Post!

elliefairholm

elliefairholm

Author Engineering Elixir Applications

@rodgco did you create a new branch when pushing the amended GitHub workflow triggers?

As for only building and pushing the images for a PR that is approved and merged - you could do this, yes, but we wouldn’t recommend it. Having your CI build a Docker tag for your PRs (even before they are approved) means that anyone (developers or QA) can easily QA your changes by running the image created in the CI e.g. in a test/staging environment.

Post #2

Popular Pragmatic topics Top

brianokken
PragProg Customers

Python Testing with pytest: pytest now requires markers to be declared (downloadable code)
Many tasks_proj/tests directories exist in chapters 2, 3, 5 that have tests that use the custom markers smoke and get, which are not decl...
#errata/book-python-testing-with-pytest
2 1374 2
New
ianwillie
PragProg Customers

Build Websites with Hugo: Code will not run in a working Hugo setup
Hello Brian, I have some problems with running the code in your book. I like the style of the book very much and I have learnt a lot as...
#question/book-build-websites-with-hugo
0 1498 3
New
edruder
PragProg Customers

Docker for Rails Developers: Notes for Rails 6.1, Ruby 2.7.2
I thought that there might be interest in using the book with Rails 6.1 and Ruby 2.7.2. I’ll note what I needed to do differently here. ...
/book-docker-for-rails-developers
9 1171 1
New
herminiotorres
PragProg Customers

Concurrent Data Processing in Elixir: various errata
Hi @Margaret , On page VII the book tells us the example and snippets will be all using Elixir version 1.11 But on page 3 almost the en...
#errata/book-concurrent-data-processing-in-elixir
15 1542 13
New
digitalbias
PragProg Customers

Build a Weather Station with Elixir and Nerves: Problem connecting to Postgres with Grafana
Title: Build a Weather Station with Elixir and Nerves: Problem connecting to Postgres with Grafana on (page 64) If you follow the defau...
#errata/book-build-a-weather-station-with-elixir-and-nerves
0 1931 4
New
akraut
PragProg Customers

Programming Phoenix LiveView: Display Image Uploads (pdf p142)
The markup used to display the uploaded image results in a Phoenix.LiveView.HTMLTokenizer.ParseError error. lib/pento_web/live/product_l...
#errata/book-programming-phoenix-liveview
2 2080 9
New
AufHe
PragProg Customers

Agile Web Development with Rails 7: page 113 - Seeing the list of products
I’m a newbie to Rails 7 and have hit an issue with the bin/Dev script mentioned on pages 112-113. Iteration A1 - Seeing the list of prod...
#question/book-agile-web-development-with-rails-7
0 2612 9
New
jonmac
PragProg Customers

Kotlin and Android Development featuring Jetpack: allprojects should be moved to settings.gradle (page 245)
The allprojects block listed on page 245 produces the following error when syncing gradle: “org.gradle.api.GradleScriptException: A prob...
#suggestion/book-kotlin-and-android-development-featuring-jetpack
1 2232 1
New
s2k
PragProg Customers

Agile Web Development with Rails 7: Reloading assets in development mode
Hi all, currently I wonder how the Tailwind colours work (or don’t work). For example, in app/views/layouts/application.html.erb I have...
#question/book-agile-web-development-with-rails-7
2 1377 4
New
jwandekoken
PragProg Customers

Programming Phoenix LiveView: Live Upload Match Error
Book: Programming Phoenix LiveView, page 142 (157/378), file lib/pento_web/live/product_live/form_component.ex, in the function below: d...
#errata/book-programming-phoenix-liveview
7 1151 10
New

Other popular topics Top

AstonJ
Tech Chat

What are you watching?
Or looking forward to? :nerd_face:
#community
480 9175 251
New
Exadra37
Linux Developer Forum>Questions/Help

AMD or Intel for Programming with Linux as the OS?
I am thinking in building or buy a desktop computer for programing, both professionally and on my free time, and my choice of OS is Linux...
#web-development#mobile#android#linux#desktop-computer#mobile-development
36 5205 10
New
Rainer
Journals & Book Clubs

Programming Erlang Book Club
My first contact with Erlang was about 2 years ago when I used RabbitMQ, which is written in Erlang, for my job. This made me curious and...
/erlang/book-programming-erlang-2nd-edition#book-club
195 6254 95
New
PragmaticBookshelf
In The Spotlight

Spotlight: Noel Rappin (Author)
“Finding the Boundaries” Hero’s Journey with Noel Rappin @noelrappin Even when you’re ultimately right about what the future ho...
#author-spotlight#web-development/rails/book-modern-front-end-development-for-rails/book-rails-5-test-prescriptions
34 3668 21
New
AstonJ
Backend Developer Forum>Chat/Discussions

Rails console using 100% CPU in dev (fix)
If you are experiencing Rails console using 100% CPU on your dev machine, then updating your development and test gems might fix the issu...
/ruby/rails
3 3478 3
New
PragmaticBookshelf
In The Spotlight

Spotlight: Paolo Perrotta (Author)
“A Mystical Experience” Hero’s Journey with Paolo Perrotta @nusco Ever wonder how authoring books compares to writing articles?...
#community#author-spotlight/book-programming-machine-learning/book-metaprogramming-ruby-2
31 3390 15
New
PragmaticBookshelf
In The Spotlight

Spotlight: James Stanier (Author) Interview and AMA!
Author Spotlight James Stanier @jstanier James Stanier, author of Effective Remote Work , discusses how to rethink the office as we e...
#pragprog#remote/book-effective-remote-work
29 3901 12
New
First poster: bot
In The News

The overengineered Solution to my Pigeon Problem
The overengineered Solution to my Pigeon Problem. TL;DR: I built a wifi-equipped water gun to shoot the pigeons on my balcony, controlle...
maxnagy.com
0 4203 0
New
PragmaticBookshelf
In The Spotlight

Spotlight: Noel Rappin (Author)
A Ruby-Centric Chat with Noel Rappin @noelrappin Once you start noodling around with Ruby you quickly figure out, as Noel Rappi...
/ruby/book-programming-ruby-3-2-5th-edition#author-spotlight/rails
41 2593 20
New
AstonJ
Backend Developer Forum>Questions/Help

Psql: error: connection to server on socket "/tmp/.s.PGSQL.5432" failed: No such file or directory
If you’re getting errors like this: psql: error: connection to server on socket “/tmp/.s.PGSQL.5432” failed: No such file or directory ...
/rails#macos/postgresql
1 1511 1
New
Back to top

Latest in PragProg

Hotwire Native for Rails Developers: Collected Errata from our class at the University of Chicago
PragProg Customers
Agile Web Development with Rails 7 p1.0—May2023: foreman Gem (page 73)
PragProg Customers
The Definitive ANTLR 4 Reference: No download link provided for TestSimple.java (Page 240)
PragProg Customers
Programming Phoenix LiveView: Wrong closing element tag (page 106)
PragProg Customers
Programming Phoenix LiveView: Typo (page 103)
PragProg Customers
Programming Phoenix LiveView: Wrong HTML comment tag in example (page 102)
PragProg Customers
Programming Phoenix LiveView: typo missing word (page 101)
PragProg Customers
Agile Web Development with Rails 8 B7.0: order_mailer_test failing (page 196)
PragProg Customers
Simplicity: Let’s Change Our World — Again
PragProg Customers
Simplicity: "detail"→"derail" (page 74, B2.0)
PragProg Customers
Agile Web Development with Rails 8: Page 9
PragProg Customers
Kotlin Coroutine Confidence: Code does not run (pg 225)
PragProg Customers
Agile Web Development with Rails 8 B7.0: partials folder (page 151)
PragProg Customers
Kotlin Coroutine Confidence: Change function name, maybe (pg 182)
PragProg Customers
Modern Front-End Development for Rails, Second Edition: can't get code to run
PragProg Customers
Kotlin Coroutine Confidence: Book & source code do not match (pg 180)
PragProg Customers
Kotlin Coroutine Confidence: Add formatter off/on comments (pg 162)
PragProg Customers
Kotlin Coroutine Confidence: What's the IntelliJ IDEA inspection? (pg 133 & 141)
PragProg Customers
Kotlin Coroutine Confidence: Add `parallel/v9` (pg 125)
PragProg Customers
Agile Web Development with Rails 8_B7.0 (pages 93/94)
PragProg Customers

View all threads ❯

Latest (all)

Wikidive - AI-Guided Wikipedia Exploration
AI In The News
Node.js v24.0.1 released!
Backend News (official)
Mind-reading AI recreates what you're looking at with amazing accuracy
AI In The News
Why do LLMs have emergent properties?
AI In The News
Announcing Ivar: Ruby’s Missing Instance Variable Typo Warnings
Backend In The News
DOGE software engineer’s computer infected by info-stealing malware
In The News
Google hits back after Apple exec says AI is hurting search
macOS In The News
Present and Future of Kotlin for Web
Backend News (official)
Plasma 6.3.5 update for Kubuntu 25.04 available via PPA
Linux News (official)
Elon Musk is responsible for “killing the world’s poorest children,” says Bill Gates
In The News
Memory Safety Features in Zig
Backend In The News
Hardening GitHub Actions: Lessons from Recent Attacks | Wiz Blog
In The News
Erlang OTP-27.3.4 released!
Backend News (official)
Scala 3.3.6 LTS is now available!
Backend News (official)
AI is Like Cars
Blogs/Articles/Talks/Podcasts

View all threads ❯

We ❤️ helpful members!

We reward our most helpful members via our MOTM scheme - by giving away a whopping 25 books per year!

Member of the Month

Devtalk Sponsors

Pragmatic Bookshelf

Practical resources that improve the lives of professional developers.

Erlang Solutions

We build trusted fault-tolerant systems that scale to billions of users.

Manning Publications

Develop your skills with books, videos, and courses.

AppSignal

Catch errors, track performance, monitor hosts and more.

WyeWorks

Enabling companies to succeed by building software people love.

Pragmatic Studio

Courses that'll move you from confusion to "Aha, now I get it!"

View all our sponsors ❯

Categories:

Popular Portals

Devtalk Sponsors

Pragmatic Bookshelf

Practical resources that improve the lives of professional developers.

Erlang Solutions

We build trusted fault-tolerant systems that scale to billions of users.

Manning Publications

Develop your skills with books, videos, and courses.

AppSignal

Catch errors, track performance, monitor hosts and more.

WyeWorks

Enabling companies to succeed by building software people love.

Pragmatic Studio

Courses that'll move you from confusion to "Aha, now I get it!"

View all our sponsors ❯

We're in Beta

About us Mission Statement See our Roadmap